Skip to content

Conversation

juj
Copy link
Collaborator

@juj juj commented Oct 4, 2025

Firefox 66 and older are unable to run the parallel test harness.

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a block on line 862 of libwebgl.js that can be deleted now too.

Otherwise lgtm

ChangeLog.md Outdated
- Chrome: v70 -> v74
- Firefox: v55 -> v65
- Minimum Firefox version was further bumped up to Firefox 68 ESR - older
Firefox versions are not able to run the parallel browser harness (#25493)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe delete the line above (and use the same "Firefox: X -> Y" format as the above bumps)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting Firefox: v55 -> v65 would lose the info on which version of Firefox added the globalThis polyfill. I think having a mention of that in the ChangeLog is valuable, since it validates that Firefox is known to unconditionally also support it.

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % changelog entry

@juj juj enabled auto-merge (squash) October 7, 2025 00:52
context.defaultFboForbidBlitFramebuffer = firefoxVersion < 67;
}
}
#endif
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of change always makes me happy!

@juj juj merged commit 7378d2f into emscripten-core:main Oct 7, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants